Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libs with Statistics endpoints #1119

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Update libs with Statistics endpoints #1119

merged 3 commits into from
Nov 17, 2023
+1,038 −75

Conversation

jaymell
Copy link
Contributor

@jaymell jaymell commented Nov 14, 2023 •
edited
Loading

Add support for two recently added Statistics endpoints:

  • Aggregate App Stats
  • Aggregate Event Types

@jaymell jaymell force-pushed the lib-stats branch 12 times, most recently from 5a0e3bd to 89ef4ba Compare November 17, 2023 03:01
@jaymell jaymell changed the title Lib stats Update libs with Statistics endpoints Nov 17, 2023
@jaymell jaymell marked this pull request as ready for review November 17, 2023 03:07
@jaymell
Copy link
Contributor Author

jaymell commented Nov 17, 2023 •
edited
Loading

Note that Aggregate Event Types is technically still hidden in our API documentation. Should we change that?

@svix-james svix-james requested a review from a team November 17, 2023 03:08
tasn
tasn reviewed Nov 17, 2023
View reviewed changes
javascript/src/index.ts Outdated Show resolved Hide resolved
@jaymell jaymell requested a review from tasn November 17, 2023 18:57
svix-onelson
svix-onelson reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@svix-onelson svix-onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Tom made a similar comment to mine, so maybe the updates are still pending.

go/statistics.go Show resolved Hide resolved
go/statistics.go Outdated Show resolved Hide resolved
@svix-james svix-james merged commit 1f8e5f2 into svix:main Nov 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-onelson svix-onelson svix-onelson left review comments

@tasn tasn tasn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaymell @tasn @svix-onelson @svix-james